Issue #2808 - Mobile: Back button does not close Entity Master dialogs and can leave an application - #2809
Open
jhou-pro wants to merge 5 commits into
Open
Issue #2808 - Mobile: Back button does not close Entity Master dialogs and can leave an application#2809jhou-pro wants to merge 5 commits into
jhou-pro wants to merge 5 commits into
Conversation
…e root URI. An application loaded from the root URI (e.g. 'https://tgdev.com:8091') used to run with a single history entry, because '_loadApplicationInfrastructureIntoHistory' bails out when '_route.path' is empty, and the subsequent transition to '/menu' lands within <iron-location>'s 200 ms 'dwell' window and is written with 'replaceState' instead of 'pushState'. Back then had nothing to move to and unloaded (or closed) an application instead of reaching '_routeChanged', where Entity Master dialogs are closed. Installed applications were affected identically, as their 'start_url' of '/login' is redirected to '/' and a redirect replaces a history entry rather than adding one. The root entry is now rewritten to the main menu URI before the first transition, so that the standard infrastructure loading applies. As part of this commit, the entry for a loaded URI is no longer recorded when it duplicates the main menu entry, which is now the case for every application loaded from the root URI.
…the same URI. History transitions, including closing of Entity Master dialogs, are performed by the '_routeChanged' observer, which <app-location> triggers by updating '_route.path'. Two adjacent entries with the same URI leave '_route.path' untouched, so the observer never ran and such a Back press was silently swallowed, requiring one more press to close a dialog. A 'popstate' handler now performs a transition that <app-location> did not report. The check is deferred, so that it does not depend on the order in which 'popstate' listeners of <iron-location> and this element are registered, and it relies on 'currentHistoryState' that '_routeChanged' assigns from an entry it has just moved to. This covers duplicate entries wherever they arise, including a '/tiny/...' entry rewritten to the main menu URI in '_tgOpenMasterAction' (#2422), which duplicates the main menu entry recorded directly below it.
…increase comprehension. * It must be functionally equivalent, even though window.history.state was replaced by currentHistoryState when they are functionally equal (empty). * Markdownisation of docs. * Improve docs (when outdated and / or plain wrong). * Add missing docs.
…rease comprehension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2808
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default
Create pull requesttoDraft pull request.Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
All existing and new Java tests pass successfully by running them with Maven.
All existing and new Web tests pass successfully.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issues might be very descriptive and serve in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does not contain significant changes, and at least one appropriate reviewer has been selected.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.
To be completed by the pull request reviewer
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).
The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
If there are significant changes (described above), special attention has been paid to them.
Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.
The issue or issues addressed by the pull request are associated with the relevant release milestone.
To be completed by the pull request reviewer once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.