Repository navigation
postgresql: AND whitespace-separated terms in SubstringSearch - #73
Merged
Merged
Conversation
SubstringSearch matched the whole query string as one ILIKE '%q%', so a multi-word search like "東京 京都" looked for that literal substring (space included) and missed content containing both words separately. Split on whitespace and AND one ILIKE per term instead, mirroring plainto_tsquery's all-terms semantics. strings.Fields also splits the ideographic space (U+3000), so full-width-spaced CJK queries work too. Single-term behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72.
SubstringSearchmatched the entire query string as a singleILIKE '%q%', so a multi-word search like東京 京都looked for that literal substring (the space included) and missed content that contains both words separately.Split the search on whitespace and AND one
ILIKEper term, mirroringplainto_tsquery's all-terms semantics (which the default tsvector path already has).strings.Fieldsalso treats the ideographic space (U+3000) as a separator, so full-width-spaced CJK queries work too. Single-term behavior is unchanged.Test added for the multi-term case.