Conversation
waredjeb
reviewed
Apr 23, 2024
waredjeb
reviewed
Apr 23, 2024
| for (const auto &point_i : lcs_i){ | ||
| for (const auto &point_j : lcs_j){ | ||
| // Calculate Euclidean distance between point_i and point_j and push it to dists | ||
| dists.push_back(std::sqrt(std::pow((point_i[0] - point_j[0]), 2) + std::pow((point_i[1] - point_j[1]), 2) + std::pow((point_i[2] - point_j[2]), 2))); |
Collaborator
There was a problem hiding this comment.
if we can avoid the std::sqrt and work with everything squared would be better
Author
There was a problem hiding this comment.
I fixed the function to output the second power of the distance, then max and min squared distances are selected. But the network is currently trained with the distance, so I still have to use sqrt for min and max distance calculation...
Collaborator
There was a problem hiding this comment.
ok, let's remember this then :)
felicepantaleo
pushed a commit
that referenced
this pull request
Apr 21, 2026
* Address review comments for L1 MET
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added plug-in for GNN and MLP networks for trackster linking.