fix(mason_logger): redraw chooseOne/chooseAny with relative cursor moves - #1680
Open
spydon wants to merge 1 commit into
Open
fix(mason_logger): redraw chooseOne/chooseAny with relative cursor moves#1680spydon wants to merge 1 commit into
spydon wants to merge 1 commit into
Conversation
spydon
force-pushed
the
fix/choose-relative-cursor-redraw
branch
from
July 20, 2026 14:08
b86b31c to
3770c1e
Compare
Author
|
This should be superseding #1672, since this fixes it for all cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Screen.Recording.2026-07-20.at.16.03.37.mov
chooseOne/chooseAnyredraw the list by saving and restoring the cursor with the DEC sequences\x1b7/\x1b8. Some terminals ignore those, so the restore is a no-op and the whole prompt gets reprinted below itself on every keypress instead of updating in place.Switched the redraw to relative cursor moves (
\x1b[<n>A+\r+\x1b[J), which are much more widely supported.Type of Change