fix: support Windows hook execution with native-asset deps - #1677
Open
amrgetment wants to merge 1 commit into
Open
fix: support Windows hook execution with native-asset deps#1677amrgetment wants to merge 1 commit into
amrgetment wants to merge 1 commit into
Conversation
amrgetment
force-pushed
the
fix/windows-native-assets-hooks
branch
2 times, most recently
from
May 18, 2026 16:23
cae83e5 to
58cb529
Compare
amrgetment
force-pushed
the
fix/windows-native-assets-hooks
branch
from
May 18, 2026 16:28
58cb529 to
e8d5214
Compare
7 tasks
|
@felangel we need this fix =)! |
Owner
Sorry I’ve been busy but this is on my todo list. I should have time to review and merge later today |
|
Would be awesome 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Closes #1676.
This PR keeps the change in a single PR and addresses the Windows hook execution regression that led to reverting win32 v6 support in #1662 (after #1650 introduced it).
What changed
Windows-safe hook execution path in
packages/mason/lib/src/hooks.dartdart runprocess path instead ofIsolate.spawnUri.--vars-input/--vars-output) so variable mutation still round-trips back to Mason.Generated hook entrypoint now supports both execution modes
--working-directory.Regression coverage
packages/mason/test/fixtures/windows_native_assets/**supports hook dependencies with native assets on Windowsinpackages/mason/test/src/hooks_test.dart.Restored
mason_loggerwin32 v6 compatibilitypackages/mason_logger/pubspec.yaml:win32: ^6.2.0packages/mason_logger/lib/src/ffi/windows_terminal.dart: reapplies the win32 v6-compatible API updates from fix(mason_logger): support win32 6.0.0 APIs #1650.Type of Change
Verification
dart analyzeinpackages/mason: ✅dart test test/src/hooks_test.dart --plain-name "supports hook dependencies with native assets on Windows"inpackages/mason: ✅dart test test/src/hooks_test.dartinpackages/mason:dartaotruntimefor the existingaot-snapshotprogrammatic usage test.dart analyzeinpackages/mason_logger: ✅Related