Repository navigation
[DEV-16758] Dynamic time period values in eval config - #4851
Merged
Merged
Conversation
…pending-api into mod/dev-16758-dynamic-date-fields-for-eval
zachflanders-frb
approved these changes
Nov 5, 2026
| type=date.fromisoformat, | ||
| help=( | ||
| "Date (YYYY-MM-DD) treated as today when resolving relative dataset values such as 'last quarter' " | ||
| "and when telling the assistant the current date. (default: today)" |
Contributor
There was a problem hiding this comment.
I wonder if we should default this to a date that corresponds to the dates in our config.json?
Contributor
Author
There was a problem hiding this comment.
Going to go ahead and merge, but I did go back and forth on this. As a default value I do prefer having today's date. And this pattern would allow us to all use the same "as-of" date for consistency across runs. My concern with a specific date as the default is that it could go unnoticed.
sethstoudenmier
deleted the
mod/dev-16758-dynamic-date-fields-for-eval
branch
November 5, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update eval config data to support dynamic time values.
Technical Details:
The current evaluation framework contains verbiage such as "last year" that requires either dynamic values or constant updates. This introduces a new pattern for defining those time values dynamically in the JSON so that when parsing the file it can generate the correct time period values.
Requirements for PR Merge:
Explain N/A in above checklist: