Repository navigation
[DEV-16408] Set toolChoice to "any" - #4821
Merged
Merged
Conversation
Contributor
Evalsnova pro
This is unexpectantly resulting in a pretty significant regression. A bunch of the cases in the eval framework are failing with: We'll want to see what is going on with this and see if can be resolved before we merge this. |
Contributor
Author
|
Using Nova Pro I'm seeing the following results in the eval framework: QAT
Tool choice branch:
|
Contributor
EvalsNova Pro
This had one error related to the DEFC filter, but this one has been failing and should be addressed in a subsequent effort. |
zachflanders-frb
approved these changes
Nov 4, 2026
| } | ||
| return self._tool_config | ||
|
|
||
| return {**self._tool_config, "toolChoice": {"auto": {}}} |
Contributor
There was a problem hiding this comment.
Auto is the default, so we don't need to explicitly set it here (although it doesn't hurt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Set
toolChoicetoanyand explicitly callexecute_filteron the last loop.Technical Details:
Requirements for PR Merge:
Explain N/A in above checklist: