Repository navigation
fix: update fedimint to resolve iroh response limit - #128
Merged
bansalayush247 merged 1 commit intoSep 21, 2026
Merged
bansalayush247 merged 1 commit into
bansalayush247 merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Fedimint dependencies from
v0.10.0tov0.12.0to address the Iroh response-size limitation affecting federation synchronization.Background
The issue was investigated and the 1 MB Iroh response limit in Fedimint
v0.10.0was identified as the strongest candidate.In
v0.10.0, Iroh responses are limited to 1,000,000 bytes. A single completed federation session can exceed this limit, causing the Observer's history worker to fail while fetching that session.Since the Observer processes sessions in order, a permanently failing session can prevent subsequent sessions from reaching database processing, effectively stopping synchronization for that federation.
The upstream fix for this response limit is included in Fedimint
v0.11.0and later. This PR updates the Observer's Fedimint dependencies tov0.12.0.Changes
v0.10.0tov0.12.0Cargo.lockto reflect the new dependency resolutionExpected Behavior
Federation synchronization should no longer fail due to the previous Iroh response-size limitation, allowing the Observer to continue processing sessions beyond the affected session.
Investigation
This issue was investigated by @elsirion. The detailed investigation is included below:
Thanks @elsirion for the detailed investigation and diagnosis.
Testing
cargo checkcargo clippy --all-targets --all-features -- -D warningscargo testClose #125