Repository navigation
Tighten LNURLw withdraw callback and timeout handling - #586
Merged
m1sterc001guy merged 1 commit intoOct 5, 2026
Merged
Conversation
Only treat an explicit {"status":"OK"} from the withdraw callback as
success, so a non-2xx or unexpected reply fails immediately instead of
waiting for a payment that was never sent.
Cut the receive wait to 1 minute and, on timeout, tell the user the
payment is still pending rather than failed: the receive keeps running
and a late payment still lands in the balance.
| /// Anything else — `{}`, a proxy's `{"detail": ...}`, a rate limiter's body — must | ||
| /// fail here, or the caller waits out its receive timeout for a payment nobody | ||
| /// sent. Errors and non-2xx statuses are already rejected by [`fetch_json`]. | ||
| fn check_withdraw_callback_response(resp: &serde_json::Value) -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
We should probably implement this in rust, not dart
m1sterc001guy
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{"status":"OK"}. Any non-2xx or unexpected reply fails right away instead of waiting on a payment that was never sent. It reusesfetch_jsonfor HTTP status and LUD-06 error handling.Found while testing LNbits vouchers on iOS: payments that stalled in flight showed "Withdraw failed" after 5 minutes even though they could still settle.