Repository navigation
feat: Federation Expiration - #574
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d420473aa8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20b284e370
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18240a2162
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc80d38af3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| hasExpired | ||
| ? l10n.federationExpiryHeadlinePast(widget.federationName) | ||
| : l10n.federationExpiryHeadline(widget.federationName), |
There was a problem hiding this comment.
When guardians publish only federation_successor, expiry is null and hasExpired is false, so this branch displays “is shutting down”; the same screen also always shows the shutdown explanation even though the banner explicitly treats a successor alone as a recommendation rather than a shutdown. Tapping the successor banner therefore escalates it into an unsupported closure warning that may prompt users to remove an address or leave unnecessarily. Add successor-only headline, title, and explanation copy when no expiry date was announced.
Useful? React with 👍 / 👎.
| Future<void> _onRegisteredPressed() async { | ||
| if (_selectedFederationExpiring) return; |
There was a problem hiding this comment.
If guardians announce a shutdown while this screen remains open, this guard still uses the one-time _expiringFederations snapshot populated by _initialize; unlike the dashboard, the screen does not consume subsequent MetaUpdated events, and the backend registration call performs no expiry check. A user who opened the form before the periodic metadata refresh can therefore register after the shutdown date appears. Refresh or subscribe to metadata before enabling/submitting registration, preferably enforcing the check in the shared backend path.
Useful? React with 👍 / 👎.
1 participant
Partially closes: #274
Adds a loud banner message when the meta in the federation has been set to indicate that the federation is expiring. Disables receives into the federation and disallows Lightning Address registrations. Details screen guides the user on what to do:
Also fixes a bug with the onchain sweep logic for both walletv2 and walletv1.