Repository navigation
build: deploy master to production - #151
Merged
Merged
Conversation
fix: mod icons that fail to load on the live catalog
- merging the deploy PR is the production deploy and a human does it on GitHub, so an agent's job ends at opening the PR and handing over the link
…149) - merging the deploy PR is the production deploy and a human does it on GitHub, so an agent's job ends at opening the PR and handing over the link
- copying every mod's icon into public/icons made this repo a host for other projects' brand assets, froze their logos at the day they were copied, and added a manual step to every mod submission - the icons the catalog already served from public/ predate this and stay - a mod whose icon stops loading is a mod to fix or drop, and the e2e icon check names it
- both 404 at the urls the catalog asks for and render as blank cards - their sites still serve a logo a browser can embed, verified cross-origin
- an icon check inside the pull request suite goes red on hosts that block or throttle github's ip ranges, so it flags mods that render fine for users and holds up unrelated work - a PR that adds a mod now has that mod's icon loaded in a browser from another origin, the only way to see a cross-origin-resource-policy block - every icon is checked the same way weekly and a failure opens an issue naming the mods, so rot gets found without gating anyone's PR - checking one url at a time is what makes the result trustworthy, a page pulling sixty images at once leaves stragglers that look broken
revert(mods): keep icon urls remote, drop the vendored copies
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
E2E_BASE_URL: 67 pass, 1 skipped, none flaky