Skip to content

click the tray icon to pop up the menu - #1640

Open
hantengc wants to merge 1 commit into
fcitx:masterfrom
hantengc:hantengc_add_traymenu
Open

click the tray icon to pop up the menu#1640
hantengc wants to merge 1 commit into
fcitx:masterfrom
hantengc:hantengc_add_traymenu

Conversation

@hantengc

@hantengc hantengc commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated tray interactions so both left- and right-clicks open the tray menu.
    • Removed accidental input method toggling when activating the status notifier or clicking the tray icon.
    • Corrected the status notifier to indicate that a menu is available.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5762c1cf-b19c-48dd-a977-2f468dd5b5c9

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1da34 and d961257.

📒 Files selected for processing (2)
  • src/modules/notificationitem/notificationitem.cpp
  • src/ui/classic/xcbtraywindow.cpp

📝 Walkthrough

Walkthrough

The change removes input-method toggling from tray activation. The status notifier reports that it is a menu. The XCB tray window opens the menu for both primary and secondary button presses.

Changes

Tray menu activation

Layer / File(s) Summary
Status notifier menu behavior
src/modules/notificationitem/notificationitem.cpp
Activate no longer toggles the input method. ItemIsMenu now returns true.
Tray button menu handling
src/ui/classic/xcbtraywindow.cpp
Primary and secondary button presses now update and display the tray menu.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: wengxt

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: clicking the tray icon opens the tray menu.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hantengc

Copy link
Copy Markdown
Contributor Author
image 左键点击弹出来的效果

@wengxt

wengxt commented Aug 15, 2026

Copy link
Copy Markdown
Member

感觉还是做成一个选项?……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants