Skip to content

Add optional atomic surrounding-text replacement contract - #1621

Draft
dismonjames wants to merge 1 commit into
fcitx:masterfrom
LumeWorks:feature/atomic-surrounding-replacement
Draft

Add optional atomic surrounding-text replacement contract#1621
dismonjames wants to merge 1 commit into
fcitx:masterfrom
LumeWorks:feature/atomic-surrounding-replacement

Conversation

@dismonjames

Copy link
Copy Markdown

Adds an ABI-additive optional input-context interface for engines that need to replace validated surrounding text without splitting deletion and commit across client transactions. D-Bus exposes it only during ProcessKeyEventBatch; Wayland v1/v2 apply deletion and text in one protocol commit. Unsupported frontends do not advertise the interface.\n\nThis is being exercised by UniLume for zero-preedit Vietnamese input; additional focused protocol tests will follow before marking ready.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: af6efa44-95af-4952-8103-3e88927e3f84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wengxt

wengxt commented Aug 2, 2026

Copy link
Copy Markdown
Member

I doubt this solves any real problem.

  1. most case, UI event is handled in singe thread
  2. dbus message order is guaranteed, only tricky thing is whether you can ensure method call to work in the same order with signal

As long as event is handled in order, there's no need to do fancy things in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants