Repository navigation
fix: prevent shared state bugs from mutable default arguments - #175
Merged
Merged
Conversation
Change `SearchManager.__init__()` and `make_searchable()` to use
`options=None` instead of `options={}` to prevent shared mutable state
across function calls.
- `SearchManager.__init__()` now creates a copy of `default_options` to
prevent mutating the class-level dictionary
- Update `SQLConstruct.init_options()` to properly handle option
priority (column-specific > passed > defaults)
- `SearchManager.attach_ddl_listeners()` now passes options to SQL
construct instances to ensure runtime-modified options are respected
This eliminates bugs where modifying options in one call could affect
subsequent calls due to shared dictionary references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
SearchManager.__init__()andmake_searchable()to useoptions=Noneinstead ofoptions={}to prevent shared mutable state across function calls.SearchManager.__init__()now creates a copy ofdefault_optionsto prevent mutating the class-level dictionarySQLConstruct.init_options()to properly handle option priority (column-specific > passed > defaults)SearchManager.attach_ddl_listeners()now passes options to SQL construct instances to ensure runtime-modified options are respectedThis eliminates bugs where modifying options in one call could affect subsequent calls due to shared dictionary references.