Skip to content

en-GB: Fix erroneous too strict rule for id_number (NI number) - #3319

Open
luke-hill wants to merge 1 commit into
faker-ruby:mainfrom
luke-hill:patch-2
Open

en-GB: Fix erroneous too strict rule for id_number (NI number)#3319
luke-hill wants to merge 1 commit into
faker-ruby:mainfrom
luke-hill:patch-2

Conversation

@luke-hill

Copy link
Copy Markdown
Contributor

I found this out by investigation that actually this would fail for a specific valid NI number (One that is known to be valid, but this system would detect it as invalid)

Original work / motivation from #3032

Motivation / Background

Fixed a bug whereby you cannot generate a valid NI number

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

I found this out by investigation that actually this would fail for a specific valid NI number (One that is known to be valid, but this system would detect it as invalid)
@luke-hill

Copy link
Copy Markdown
Contributor Author

@stefanjcollier @stefannibrasil minor item to review. Should be an easy merge and fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant