[Nexthop][fboss2-dev] add config interface <intf> name <value> attribute - #1472
Open
benoit-nexthop wants to merge 2 commits into
Open
[Nexthop][fboss2-dev] add config interface <intf> name <value> attribute#1472benoit-nexthop wants to merge 2 commits into
config interface <intf> name <value> attribute#1472benoit-nexthop wants to merge 2 commits into
Conversation
InterfaceList now accepts a purely-numeric argument and resolves it as a port logical ID or an interface ID, so e.g. `fboss2-dev config interface 2001 mtu 9000` works on the interface with ID 2001. Name lookups always take precedence over ID lookups, consistently for both ports and interfaces: port name -> port logical ID -> interface name -> interface ID. Adds PortMap::getPortNameForLogicalId(), the reverse of the existing getPortLogicalId().
Sets the name of an L3 interface. Combined with ID-based interface lookup, this allows naming an interface that has no name yet, e.g. `fboss2-dev config interface 3001 name svi_mgmt`. Validation: the name must be non-empty, must not be purely numeric (it would shadow lookups by port/interface ID), must not collide with an existing port or interface name, and can only target a single interface at a time. The session's port map is rebuilt after a rename so subsequent lookups in the same session see the new name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D114968340. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #1471 — this PR's diff includes that PR's commit until it merges; only the last commit (
fboss2: add \config interface name ` attribute`) is new here.Summary
Add a
nameattribute tofboss2-dev config interfaceto set the name of an L3 interface. This allows naming an interface that has no name yet, e.g.fboss2-dev config interface 3001 name svi_mgmt.Validation:
The session's port map is rebuilt after a rename so subsequent lookups in the same session see the new name.
Test Plan
Unit tests cover renaming by port name, naming a nameless interface addressed by its interface ID, idempotent rename, and the rejection cases.