Skip to content

[Nexthop][m4062nhp] Add embedded sensors - #1467

Open
marif-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:marif.fboss-m4062nhp-add-embedded-sensors
Open

[Nexthop][m4062nhp] Add embedded sensors#1467
marif-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:marif.fboss-m4062nhp-add-embedded-sensors

Conversation

@marif-nexthop

@marif-nexthop marif-nexthop commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Add the embedded temperature sensor devices on the m4062nhp SCM (CPU TCTL/TCCD, NVMe composite, NIC PHY/MAC) to platform_manager and sensor_service, with thresholds from the hardware thermal spec.

Test Plan

Loaded the image on a test device and verified that the new sensors appear in the PlatformManager device map and report values via sensor_service_client.

# ./bin/sensor_service_client

Sensor Service Output:

Slot Path: /:

+---------------------+-------+--------+---------------+------------+-------------+-------------------------------------------+
| name                | value | status | criticalRange | alarmRange | lastUpdated | sysfsPath                                 |
+---------------------+-------+--------+---------------+------------+-------------+-------------------------------------------+
| CPU_TCCD1_TEMP      | 45.88 | PASS   | [, 120.00]    | [, 95.00]  | 2s ago      | /run/devmap/sensors/CPU_TEMP/temp3_input  |
| CPU_TCCD2_TEMP      | 44.25 | PASS   | [, 120.00]    | [, 95.00]  | 2s ago      | /run/devmap/sensors/CPU_TEMP/temp4_input  |
| CPU_TCTL_TEMP       | 68.38 | PASS   | [, 120.00]    | [, 95.00]  | 2s ago      | /run/devmap/sensors/CPU_TEMP/temp1_input  |
| DPM_2_VIN           | 12.21 | PASS   | [9.00, 14.00] | [, ]       | 2s ago      | /run/devmap/sensors/DPM_2/in1_input       |
| DPM_VIN             | 12.20 | PASS   | [9.00, 14.00] | [, ]       | 2s ago      | /run/devmap/sensors/DPM/in1_input         |
| NIC_MAC_TEMP        | 40.00 | PASS   | [, 110.00]    | [, 100.00] | 2s ago      | /run/devmap/sensors/NIC_TEMP/temp2_input  |
| NIC_PHY_TEMP        | 40.00 | PASS   | [, 110.00]    | [, 100.00] | 2s ago      | /run/devmap/sensors/NIC_TEMP/temp1_input  |
| NVME_COMPOSITE_TEMP | 23.85 | PASS   | [, 95.00]     | [, 90.00]  | 2s ago      | /run/devmap/sensors/NVME_TEMP/temp1_input |
+---------------------+-------+--------+---------------+------------+-------------+-------------------------------------------+

Add the embedded temperature sensor devices on the m4062nhp SCM (CPU
TCTL/TCCD, NVMe composite, NIC PHY/MAC) to platform_manager and
sensor_service, with thresholds from the hardware thermal spec.
@meta-codesync

meta-codesync Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D114963379. (Because this pull request was imported automatically, there will not be any future comments.)

@marif-nexthop
marif-nexthop marked this pull request as ready for review August 6, 2026 03:14
@marif-nexthop
marif-nexthop requested a review from a team as a code owner August 6, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant