Toolbar: support responsive OverflowList composition - #4868
Draft
ernestt wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsMoreMenu (@astryxdesign/core) · View in Storybook
Toolbar (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 moderate. Toolbar - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft explores the small Core changes needed to make OverflowList a safe responsive strategy inside Toolbar. It is intentionally separate from #4818 so the integration can be reviewed on its own.
Why these changes are needed
OverflowList renders a hidden inert measurement copy of every child. Toolbar currently queries every descendant button, input, or tabindex, so it includes those copies in its roving order. Toolbar slots also keep their intrinsic width, which prevents OverflowList from observing the actual constrained space. Finally, data-only MoreMenu items cannot represent controlled checkbox actions without losing their component state model.
Scope and risk
Storybook
Core / Toolbar / Composition: Responsive Overflow
Use the width slider to force actions into MoreMenu, then toggle actions both inline and from the overflow menu to verify state continuity.
Validation