docs(storybook): remove blank line inside RichTextEditorAutoLinkPlugin @example - #4848
Open
josephfarina wants to merge 1 commit into
Open
docs(storybook): remove blank line inside RichTextEditorAutoLinkPlugin @example#4848josephfarina wants to merge 1 commit into
josephfarina wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsRichTextEditor (@astryxdesign/lab) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
@exampleblock inRichTextEditorAutoLinkPlugin.tsxhad a blank line between the import statement and the JSX inside the code fence. Storybook's markdown renderer can interpret a blank line as ending the code fence, which makes the rest of the example render as raw text instead of code. Removed the blank line so the import and JSX stay in one contiguous block.No behavior change; JSDoc comment whitespace only.
Checklist
pnpm --filter @astryxdesign/core typecheck:docspassestsc --project packages/cli/tsconfig.template-docs.json --noEmitpasses>inside the@examplecode block@exampleNotes for reviewers
Two related Storybook
@exampleissues were found but deferred to avoid conflicts with open PRs:RichTextEditorToolbar.tsx(same blank-line issue) is being edited in the same@exampleblock by Refresh RichTextEditor visuals and toolbar #4818; leaving it to land there.globalIconRegistry.tsx(JS comments inside a code block) sits in a region feat(chat): add useChatSpeech hook and ChatSpeechButton for text-to-speech #3934 deletes.Night Watch — Doc Reviewer