fix(hooks): cycle useTreeFocus typeahead on repeated letters - #4844
Open
alex-js-ltd wants to merge 3 commits into
Open
fix(hooks): cycle useTreeFocus typeahead on repeated letters#4844alex-js-ltd wants to merge 3 commits into
alex-js-ltd wants to merge 3 commits into
Conversation
|
@alex-js-ltd is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
alex-js-ltd
force-pushed
the
fix/tree-focus-typeahead-cycling
branch
from
August 10, 2026 08:55
d21c9bd to
f92e230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4843.
Problem
useTreeFocushas its own typeahead implementation, which has drifted from the shareduseTypeaheadbehavior.This causes three related issues:
"aa"instead of cycling through matches;For example, pressing
ptwice quickly in theFullyExpandedTreeList story stalls onpublicinstead of advancing topackage.json.Fix
Align
useTreeFocuswith the typeahead semantics being established in #3797:No public API changes.
Tests
Added regression coverage for all three cases:
Before the fix: 3 failing, 13 passing
After the fix: 16 passing
Also verified the full
uitest suite (6472/6472 passing), Prettier, ESLint,coretypecheck, andcheck:changesets.Reproduce manually
Open the [FullyExpanded story](https://facebook.github.io/astryx/storybook/index.html?path=/story/core-treelist--fully-expanded), click a row, then press
ptwice quickly.Before: focus stops on
public.After: focus advances to
package.json.