docs(core): replace ellipsis char in DateRangeInput prop prose - #4841
Open
josephfarina wants to merge 1 commit into
Open
docs(core): replace ellipsis char in DateRangeInput prop prose#4841josephfarina wants to merge 1 commit into
josephfarina wants to merge 1 commit into
Conversation
The weekStartsOn description used a Unicode ellipsis (U+2026) inside prose: '0 = Sunday ... 6 = Saturday'. The ellipsis stood for a range, so replace it with 'to' as in DateInput and DateTimeInput. Prose only; no meaning changed. Found during Night Watch doc review.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsDateRangeInput (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 critical. DateRangeInput - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
weekStartsOndescription inDateRangeInput.doc.mjsused a Unicode ellipsis (U+2026) inside prose:0 = Sunday ... 6 = Saturday. The ellipsis stood for a numeric range, so replace it withto, matching the same fix already applied toDateInputandDateTimeInput.Prose only; no meaning changed.
Validation
pnpm --filter @astryxdesign/core typecheck:docspassesastryx component DateRangeInput --lang denserenders cleanlyNight Watch — Doc Reviewer