fix(empty-state): place rest spread before contract role so consumers cannot clobber it - #4826
Open
cixzhang wants to merge 1 commit into
Open
fix(empty-state): place rest spread before contract role so consumers cannot clobber it#4826cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
… cannot clobber it
EmptyState sets role="status" for live-region semantics. The rest spread
was placed after it, which means a consumer passing role via BaseProps
would silently override the component's contract.
Move {...props} before role="status" so the component always wins on its
contract prop, per the established precedence pattern (rest -> contract ->
merged styles).
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsEmptyState (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmptyState sets
role="status"for live-region semantics (contentannounced to screen readers). The rest spread (
{...props}) was placedafter it, which means a consumer passing
rolevia BaseProps wouldsilently override the component's contract prop.
Moves
{...props}beforerole="status"so the component always wins,per the established rest-spread precedence pattern used by other Astryx
components (rest first, then contract props, then merged styles).
No behavior change for consumers who don't pass
role(the common case).Night Watch -- Component Auditor