fix: strip trailing separators from path args on Windows - #1950
Open
GhostCoder6969 wants to merge 1 commit into
Open
GhostCoder6969 wants to merge 1 commit into
GhostCoder6969 wants to merge 1 commit into
Conversation
Filesystem calls reject paths like 'C:\Program Files\' with OS error 123, so normalize CLI path arguments through their components before use. Roots are kept intact and behavior outside Windows is unchanged. Closes eza-community#404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #404. On Windows the fs calls reject a path like
C:\Program Files\with OS error 123, so I normalize CLI path arguments through their components before anything touches the filesystem. Roots (/,C:\) survive the round trip, and outside Windows the argument passes through byte-identical.How Has This Been Tested?
I could not repro the Windows error on Linux, so I verified the normalization logic with unit tests (trailing separators go, roots stay) plus the full
cargo testsuite,cargo fmt --check, and zero-warningcargo clippy. The Windows CI job should show the original command listing the directory. Happy to adjust the approach if you would rather fix this deeper inFile.No new flags, so no completions, man, README, or help changes needed. Commit follows conventional commits with Closes #404.