Repository navigation
fix(knitr): code compiles when eval = FALSE - #548
Merged
Merged
Conversation
JosiahParry
reviewed
Sep 25, 2026
JosiahParry
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547.
I think the original intent maybe was something like this (from the knitr-engine test):
but this actually still works with a guard to return early when
eval = FALSEbecause the preamble chunks are combined with theoutchunk, compiled, and evaluated there.Note: in knitr_engine.R, I took the liberty of cleaning up some of the code, e.g., using
rlang::is_*functions and replacinglapply(options$preamble, knitr::knit_code$get)withknitr::knit_code$get(options$preamble)since it is already vectorized (or anyway it just subsets a list of code chunks with the character vector inpreamble).