Skip to content

fix: garbage-collect orphaned download state - #2249

Open
abendrothj wants to merge 2 commits into
exo-explore:mainfrom
abendrothj:fix/2136-gc-orphaned-downloads
Open

fix: garbage-collect orphaned download state#2249
abendrothj wants to merge 2 commits into
exo-explore:mainfrom
abendrothj:fix/2136-gc-orphaned-downloads

Conversation

@abendrothj

Copy link
Copy Markdown

Summary

  • detect download state owned by node IDs no longer present in topology
  • emit the existing NodeTimedOut cleanup event for those retired IDs
  • preserve downloads belonging to connected nodes
  • add regression tests for orphan detection and pending-download removal

Testing

  • uv run pytest src/exo/master/tests/test_orphaned_downloads.py src/exo/shared/tests/test_apply/test_apply_node_download.py
  • uv run basedpyright src/exo/master/main.py src/exo/master/tests/test_orphaned_downloads.py src/exo/shared/tests/test_apply/test_apply_node_download.py
  • uv run ruff check src/exo/master/main.py src/exo/master/tests/test_orphaned_downloads.py src/exo/shared/tests/test_apply/test_apply_node_download.py

Fixes #2136


Refiled from #2210, which was closed unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DownloadPending entries for retired node IDs never GC'd — infinite _delete_download loop survives all restarts

1 participant