Skip to content

Make so the test file name is formated in snakecase by generator #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotp merged 2 commits into from
Jul 26, 2025
Merged

Make so the test file name is formated in snakecase by generator #1765

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
525e2f0
Make so the test file name is formated in snakecase.
meatball133 Jul 25, 2025
ba9ffb4
Use the underscore method instead
meatball133 Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion generatorv2/lib/generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def initialize(exercise = nil)
@exercise = exercise
end

def generate(result_path = "./exercises/practice/#{@exercise}/#{@exercise}_test.rb")
def generate(result_path = "./exercises/practice/#{@exercise}/#{to_snake(@exercise)}_test.rb")
json = remote_files
uuid = toml("./exercises/practice/#{@exercise}/.meta/tests.toml")
additional_json(json)
Expand All @@ -38,6 +38,10 @@ def camel_case(str)
str.split(/[-_]/).map(&:capitalize).join
end

def to_snake(str)

@kotp kotp Jul 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see camel_case right above here, should this be snake_case instead?

@kotp kotp Jul 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I see underscore is very similar. And the tests file has not been update to reflect testing of this new public method.

@meatball133 meatball133 Jul 26, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't think about that method. Was quite tired when I made this commit, but good suggestion.

str.gsub(/([a-z\d])([A-Z])/, '\1_\2').tr("-", "_").downcase

@kotp kotp Jul 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not...

Suggested change
str.gsub(/([a-z\d])([A-Z])/, '\1_\2').tr("-", "_").downcase
str.tr("-", "_").downcase

Are there tests for this file?

end

def skip?
if @first
@first = false
Expand Down
Loading