Remove temporary hack since Roc issue #10303 is now fixed - #202
Open
ageron wants to merge 1 commit into
Open
Conversation
Anton-4
approved these changes
Aug 5, 2026
Contributor
|
Oh it does look like the test got stuck |
Contributor
Author
|
Ah yes, the roc-test-runner uses the Roc compiler available via the install script, which is a few days old so it doesn't yet have the fix that unblocks this exercise. I guess we just have to wait for a few days, or we could tweak the test runner to make it use the very latest Roc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that roc-lang/roc#10303 is fixed, we can remove the temporary hack that made the tests pass for
sgf-parsingand replace it with the proper solution.