Migrate from Spago 0.21.0 to Spago 1.0.3 #323
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,23 +1,21 @@ | ||||||
| #!/usr/bin/env bash | ||||||
|
|
||||||
| # This script will update spago.yaml and .gitignore of all exercises | ||||||
| # using the master files from the project template (template/). | ||||||
|
|
||||||
| set -e | ||||||
| set -o pipefail | ||||||
| set -u | ||||||
|
|
||||||
| base_dir=$(builtin cd "${BASH_SOURCE%/*}/.." || exit; pwd) | ||||||
| template_dir="${base_dir}/template" | ||||||
|
|
||||||
| for exercise_dir in "$base_dir"/exercises/*/*; do | ||||||
| [ -d "${exercise_dir}" ] || continue | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| slug=$(basename "${exercise_dir}") | ||||||
|
|
||||||
| echo "Working in ${exercise_dir}..." | ||||||
|
|
||||||
| sed -e "s/exercise-template/${slug}/" < "${template_dir}/spago.yaml" > "${exercise_dir}/spago.yaml" | ||||||
| cp "${template_dir}/.gitignore" "${exercise_dir}/.gitignore" | ||||||
| done | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,8 +32,7 @@ | |
| ".meta/Exemplar.purs" | ||
| ], | ||
| "invalidator": [ | ||
| "spago.yaml" | ||
| ] | ||
| }, | ||
| "exercises": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /node_modules/ | ||
| /output/ | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,7 @@ | |
| ".meta/Exemplar.purs" | ||
| ], | ||
| "invalidator": [ | ||
| "spago.yaml" | ||
| ] | ||
| }, | ||
| "forked_from": [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package: | ||
| name: annalyns-infiltration | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
|
Member
There was a problem hiding this comment. Why is there a per-exercise
Contributor
Author
There was a problem hiding this comment. I think it's a good idea to have exercise-scoped .gitignore because if someone downloads an independent exercise, we don't know what context it might exist in, as someone could want to work on an exercise within their own Git repo, so being self-contained guarantees that the right things will be ignored. BTW, this PR is a mess because I screwed things up, so I'm preparing to address other stuff and create a new PR when I'm ready.
Contributor
Author
There was a problem hiding this comment. I meant, the test runner one, where I have a new one exercism/purescript-test-runner#64
Member
There was a problem hiding this comment. None (or very few) of the other tracks use per-exercise
Contributor
Author
There was a problem hiding this comment. I do think packaging directories with their own scoped .gitignore is the best way to go, and that it's a mistake that it's not a standard practice throughout Exercism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /node_modules/ | ||
| /output/ | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package: | ||
| name: accumulate | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /node_modules/ | ||
| /output/ | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package: | ||
| name: acronym | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /node_modules/ | ||
| /output/ | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For supply-chain security and consistency with the pinned
actions/checkoutandsetup-purescriptsteps,actions/setup-nodeshould be pinned to a specific commit SHA instead of a mutable@v4tag.