Issue #24 - Use ELK layout to position SVG tasks + links

[LudoBroche]

PR summary

From the graph/tasks geometry ELK representation, we now used ELK to compute the tasks' optimal positions and link routing. The computed ELK layout is used to position the tasks and draw the links.

AI Disclosure

• Claude used to pre-review the PR
• Claude used to give advice on the pytest coverage plan.
• Claude used to render the svg collage of all the workflow svgs in the PR comment

[codecov]

Codecov Report

❌ Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/ewoksdraw/svg/svg_task_group.py	83.33%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[LudoBroche]

Tested with ewoks examples:

for graph in acyclic1 acyclic2 acyclic3 cyclic1 demo empty self_trigger triangle1
do
    pixi run graph-to-svg --test "$graph"
done

Seems to be working nicely.

[loichuder]

Not sure this is the best place nor the best name for this module.

Should it not be in svg ? Or even put the function in svg_task_group?

[LudoBroche]

Well, it's a converter from: ewoks graph -> SVG
In the same module we have: elk_link_group_builder.py elk graph -> SVG and elk_converter.py SVG -> elk graph.

I don't think it should be svg_task_group, since it handles Ewoks graphs.
I can create a new module for it. What do you think?

[loichuder]

ewoksdraw/ewoks_to_svg ?

[LudoBroche]

@loichuder I apply your suggestions.
Two points are still pending:

1. ewoks_task_group_builder.py
2. The new API location. I tried to follow the Ewoks' project style by creating a binding.py. Let me know what you think.

[loichuder]

@loichuder I apply your suggestions. Two points are still pending:

1. [ewoks_task_group_builder.py](https://github.com/ewoks-kit/ewoksdraw/pull/30#discussion_r3903867146)

2. The new API location. I tried to follow the Ewoks' project style by creating a `binding.py.` Let me know what you think.

Above I suggested ewoks_to_svg as the new home for ewoks_task_group_builder. It can also be the home of graph_to_svg then?

[loichuder]

Looks good!

[loichuder]

Suggested change

"""An ELK child before layout."""

🙃