fix test_in_place_installer - #338
Open
woutdenolf wants to merge 1 commit into
Open
Conversation
woutdenolf
force-pushed
the
fix_ci_only_pip
branch
from
August 29, 2026 09:30
a2acd5c to
550f5c6
Compare
woutdenolf
force-pushed
the
fix_ci_only_pip
branch
from
August 29, 2026 09:34
550f5c6 to
3412d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
fix test_in_place_installer: this tests that
get_in_place_installerdoes not return a manager when it is tagged to not be able to install in-place. It will pick another manager that can install in-place. If there are none it raises RuntimeError which is still valid result for this test.In the Github CI it has uv to fall back on, but in the nightly gitlab CI it does not.
AI Disclosure