Skip to content

docs(rbac): correct assigned_inboxes comment for secure-by-default agent (CRM-181) #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gomessguii merged 1 commit into from
Aug 17, 2026
Merged

docs(rbac): correct assigned_inboxes comment for secure-by-default agent (CRM-181) #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,12 @@ def assigned_inboxes
# treated as false here.
#
# There is deliberately NO zero-membership fallback: "see everything" comes
# ONLY from the conversations.read_all grant (which the upgrade migration
# gave every pre-existing role, so revoking it is the admin's explicit act).
# ONLY from the conversations.read_all grant. The default `agent` role is
# SECURE-BY-DEFAULT — it does NOT hold read_all (CRM-181), so an agent sees
# only its member inboxes and an agent with no membership sees nothing until
# assigned; account_owner/super_admin keep read_all. The evo-auth CRM-181
# data-migration revokes read_all from the system `agent` role on upgrade;
# for CUSTOM roles an admin created, revoking is the admin's explicit act.
# The old `inbox_members.empty? -> Inbox.all` degrade made that revoke
# unenforceable for users with no memberships — the common state, since
# most installs never assigned inboxes.
Expand Down
Loading