Repository navigation
Accept not_yet_revealed fork choice validity - #61
Merged
Merged
Conversation
Lighthouse reports Gloas fork choice nodes whose payload envelope has not arrived as not_yet_revealed, and rejecting it fails the whole fork choice response.
![redpandabot[bot]](https://avatars.githubusercontent.com/in/3749543?s=60&v=4){kind=small}
There was a problem hiding this comment.
Adds ForkChoiceNodeValidityNotYetRevealed to the fork choice validity enum, its string table and FromString parser, plus a round-trip test. The constant is appended so existing iota values are unchanged, the string matches the upstream beacon-APIs#658 spec exactly, and no other switch or mapping over this enum exists in the repo. The change is complete and correct.
Reviewed 2 changed file(s) @ 7b1835e6 — no blocking issues found.
"He who digs a pit for others falls into it himself." — Eastern European proverb
Contributor
|
we should not use fork choice v1 endpoint after gloas, please take a look at ethereum/beacon-APIs#615 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lighthouse reports Gloas fork choice nodes whose payload envelope has not arrived as
not_yet_revealed(proposed in ethereum/beacon-APIs#658). Rejecting it fails the whole/eth/v1/debug/fork_choiceresponse, so Sepolia lighthouse fork choice snapshots stopped at the Glamsterdam fork. Adds the value toForkChoiceNodeValidity.