Repository navigation
fix: build with Go 1.26.10 for the eMudhra CA compromise - #267
Merged
Merged
Conversation
samcm
approved these changes
Oct 21, 2026
samcm
left a comment
Member
There was a problem hiding this comment.
Reviewed the Go 1.26.10 bump: versions, image tags and pins check out.
There was a problem hiding this comment.
Raises the go.mod minimum to go 1.26.10 so all builds (Docker, goreleaser, CI) require the toolchain with the crypto/x509 eMudhra fix, and adds check-latest: true to the setup-go steps so CI picks up the latest 1.26 patch. The go1.26.10 release is real, the floating golang:1.26 image and setup-go '1.26' ranges resolve to ≥1.26.10, and no other pins are left behind. Clean, targeted security remediation.
Reviewed 4 changed file(s) @ 08ae8548 — no blocking issues found.
"There are only two industries that call their customers 'users': illegal drugs and software." — Edward Tufte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight eMudhra intermediate CA private keys were compromised (Mozilla, Google), and Go 1.26.10/1.27.3 ship the
crypto/x509fix, so every binary built with an older toolchain still trusts certificates minted with those keys. This raises thego.modminimum togo 1.26.10, so Docker, goreleaser and CI builds can no longer silently use an older toolchain, and moves pinned or pre-1.26golangbuilder images and setup-go versions to match.