Repository navigation
Conversation
Author
|
Could someone approve the workflow run? It is sitting at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the target/max half of #88. The task watches proposed blocks and checks the blob count against the chain's target or max, reading both numbers from the execution client's
eth_configinstead of a number written into the playbook, because the consensus config only publishesMAX_BLOBS_PER_BLOCKand carries no target at all. A block over max aborts rather than counting as a miss, since that is a violation and not just an underfilled block.I left the pre-propose pool snapshot out until you answer the question in the issue, so this does not guess between a lead-time knob on this task and a separate recorder task. I also made it a new task rather than more flags on
check_consensus_block_proposals, since the limits come from an execution RPC and that check is consensus only, but it folds in easily if you would rather have it there.