feat(tests): EIP-7954 checklist triage and parent initcode-limit transition test - #3550
Closed
axiosdevs wants to merge 1 commit into
Closed
feat(tests): EIP-7954 checklist triage and parent initcode-limit transition test#3550axiosdevs wants to merge 1 commit into
axiosdevs wants to merge 1 commit into
Conversation
…sition test Bring the EIP-7954 checklist from 0% to 100%: tag the existing size-limit tests with the checklist items they pin (initcode behaviour by opcode and by creation transaction, opcode out-of-bounds at max and max+1, created address, activation at the fork, and the modified initcode validity constraint before/after the fork), and record the rest as not applicable or as covered elsewhere. External coverage points at the EIP-8037 and EIP-3860 suites for the opcode-level gas boundaries and exceptional abort at the new sizes, so those are not duplicated here. Add the one missing arm: a create transaction whose initcode is exactly the parent fork's maximum is accepted both before and after the transition, mirroring the existing parent max-code-size test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
I will close this one since it is duplicated by PR #3546 , which has more test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist triage for EIP-7954 (
tests/amsterdam/eip7954_increase_max_contract_size), whichuv run checklistreported at 0% because none of its 21 tests carried a marker and it had noeip_checklist_not_applicable.txt/eip_checklist_external_coverage.txt.opcode/test/execution_context/initcode/behavior{,/tx,/opcode},opcode/test/out_of_bounds/verify/{max,max_plus_one},opcode/test/contract_creation/address,opcode/test/gas_usage/extra_gas,opcode/test/fork_transition/at, andmodified_transaction_validity_constraint/test/fork_transition/{rejected_before_fork,accepted_after_fork,rejected_after_fork}. Where only one parametrization is the covering case (at_max/over_maxof the creation-transaction initcode test) the mark sits on thepytest.param.tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_state_gas_create.pyandtests/shanghai/eip3860_initcode/test_initcode.py(which fills atfork.max_initcode_size()on Amsterdam), so the entries point there instead of duplicating them.test_parent_max_initcode_size_across_fork: a create transaction whose initcode is exactly the parent fork'smax_initcode_size()is accepted in the pre-fork block and again after the transition — theaccepted_before_forkarm of the modified validity constraint, mirroring the existingtest_parent_max_code_size_across_fork.Result:
uv run checklist tests/amsterdam/eip7954_increase_max_contract_size→ 22/22, no conflicting items. (The template rowtransaction_type/test/intrinsic_validity/data_floor_above_intrinsic_gas_coststill shows as open on this branch; that is the duplicated-ID artifact fixed in #3544 and goes away once that lands.)Verification:
uv run fill tests/amsterdam/eip7954_increase_max_contract_size --until Amsterdam— 108 passed;ruff check/ruff format,mypyandcodespellclean on the touched files.Related Issues or PRs
Related to the checklist tracking in #3217. Follows the EIP-8246 triage in #3533 for structure.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture
🤖 Generated with Claude Code