Skip to content

feat(tests): EIP-8246 checklist, focus on #3217 items - #3533

Merged
LouisTsai-Csie merged 5 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/eip8246-checklist
Sep 7, 2026
Merged

feat(tests): EIP-8246 checklist, focus on #3217 items#3533
LouisTsai-Csie merged 5 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/eip8246-checklist

Conversation

@fselmo

@fselmo fselmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Go through EIP-8246 checklist items in #3217 📝

Related Issues or PRs

#3217

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Screenshot 2026-09-04 at 17 20 18

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (903b48f) to head (552dfda).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3533   +/-   ##
================================================
  Coverage            94.01%   94.01%           
================================================
  Files                  624      624           
  Lines                36912    36912           
  Branches              3326     3326           
================================================
  Hits                 34702    34702           
  Misses                1533     1533           
  Partials               677      677           
Flag Coverage Δ
unittests 94.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo
fselmo force-pushed the feat/eip8246-checklist branch from 741c42d to bf52b3e Compare September 4, 2026 20:15
@fselmo
fselmo force-pushed the feat/eip8246-checklist branch from bf52b3e to 94ab706 Compare September 4, 2026 21:00
@fselmo
fselmo marked this pull request as ready for review September 4, 2026 23:16

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, really nice enhancement!

@LouisTsai-Csie LouisTsai-Csie added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels Sep 7, 2026
@LouisTsai-Csie
LouisTsai-Csie merged commit e5dc2e0 into ethereum:forks/amsterdam Sep 7, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants