feat(tests): map ethrex's frame-transaction rejection reasons - #3413
Merged
spencer-tb merged 1 commit intoAug 22, 2026
Conversation
The mapper had no TYPE_6_* entries, so every frame-transaction rejection reached the consume-engine simulator as "Undefined exception message" even when the block was correctly rejected. 51 of the 62 failures in the frames hive suite were this. Adds the three frame-transaction exceptions plus the two fee-overflow cases. TYPE_6_INVALID_FRAME_FORMAT carries three alternatives because ethrex reaches that conclusion three ways: the static-validation reason, signature-entry structure checked inside signature validation, and a frame or signature field too wide for its type rejected while decoding. Depends on lambdaclass/ethrex#7197, which makes ethrex report these reasons distinctly instead of returning the approval error for all of them.
spencer-tb
approved these changes
Aug 22, 2026
spencer-tb
left a comment
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for defining these :)
spencer-tb
added
C-feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8141 #3413 +/- ##
==========================================================
Coverage ? 93.17%
==========================================================
Files ? 576
Lines ? 33250
Branches ? 2975
==========================================================
Hits ? 30980
Misses ? 1578
Partials ? 692
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
merged commit Aug 22, 2026
2094346
into
ethereum:eips/amsterdam/eip-8141
26 checks passed
16 tasks
spencer-tb
pushed a commit
that referenced
this pull request
Aug 22, 2026
spencer-tb
pushed a commit
that referenced
this pull request
Aug 22, 2026
gurukamath
pushed a commit
that referenced
this pull request
Aug 26, 2026
gurukamath
pushed a commit
that referenced
this pull request
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EthrexExceptionMapperhas no entries for the frame-transaction exceptions, so every type-0x06rejection reachesconsume-engineas "Undefined exception message" even when the block was correctly rejected. That is 51 of the 62 failures in theframeshive suite.Adds the three
TYPE_6_*exceptions plusGASPRICE_OVERFLOWandPRIORITY_OVERFLOW.TYPE_6_INVALID_FRAME_FORMATis a regex because ethrex reaches it three ways: the static-validation reason, signature-entry structure checked during signature validation, and a field too wide for its type rejected while decoding.The client side is already on
lambdaclass/ethrex@frames-devnet-0, the branch hive builds, so this carries no ordering constraint.