Fix(gpio): Keep XTAL32K off unless configured - #6075
Open
JurajSadel wants to merge 1 commit into
Open
Conversation
JurajSadel
requested review from
MabezDev,
bjoernQ,
bugadani and
playfulFence
as code owners
August 7, 2026 15:37
bugadani
reviewed
Aug 7, 2026
Comment on lines
+10
to
+11
| { pin = 0, analog = { 0 = "XTAL_32K_N" }, lp = { 0 = "LP_GPIO0" } }, | ||
| { pin = 1, analog = { 0 = "XTAL_32K_P" }, lp = { 0 = "LP_GPIO1" } }, |
Contributor
There was a problem hiding this comment.
Keep the lp columns aligned, please
bugadani
reviewed
Aug 7, 2026
| or any other function (including via `steal` / `AnyPin`) while the crystal is active. | ||
| When disabled (default), XTAL32K stays off so those pins can be used as hi-Z GPIO." | ||
| default: | ||
| - value: false |
Contributor
There was a problem hiding this comment.
Technically this goes against "esp-config does not change public API" so this will need @MabezDev 's approval. This could turn into a cargo feature if the API change is a problem.
bugadani
reviewed
Aug 7, 2026
| @@ -0,0 +1,31 @@ | |||
| //! Build-time configuration of the external 32 kHz crystal (XTAL32K). | |||
Contributor
There was a problem hiding this comment.
This is a very arbitrary folder for this... maybe move to soc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5563
Changelog
esp-hal
ESP_HAL_CONFIG_USE_XTAL32Kopts in to external 32 kHz crystal (powers it, defaults slow clock, removes crystal pads fromPeripherals)