Rework LP pin traits - #6073
Open
bugadani wants to merge 1 commit into
Open
Conversation
…f the low-power number Co-authored-by: Cursor <cursoragent@cursor.com>
bugadani
requested review from
MabezDev,
SergioGasquez,
bjoernQ and
playfulFence
as code owners
August 7, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #6060
Changelog
esp-hal
set_analogand the touch pad setup no longer clear the open-drain bit of another pad onesp32, which numbers its low-power pads differently from its digital ones.
gpio::LpPinWithResistors.gpio::LpPinnow covers every low-power pad, and the pullresistors of a pad are reached through the driver instead.
Ext1WakeupSource::newandRtcioWakeupSource::newtake&mut dyn LpPinon every chip.Migration guide
esp-hal/GPIO
LpPinWithResistorsis replaced byLpPinThe trait held the pull resistor controls of a low-power pad. Those are internal to
esp-halnow, soone trait covers every low-power pad. Name
LpPinin a bound or a trait object where you namedLpPinWithResistors:Use
InputorFlexto set the pull resistors of a pad. A wake pad keeps the resistors that itsdriver configured.