esp-hal(i2c): Adds v4 clocks - #6033
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I don't think we're getting the versions wrong, but this is suspicious |
Yes, on main i2c tests pass, I will investigate |
|
/hil full --test i2c |
|
Triggered full HIL run for #6033. Run: https://github.com/esp-rs/esp-hal/actions/runs/30984720354 Status update: ❌ HIL (full) run failed (conclusion: failure). |
|
Just tried running i2c tests locally on C61 and S31 and no issues |
playfulFence
left a comment
playfulFence
left a comment
There was a problem hiding this comment.
Thanks!
I slightly dislike this naming though, but it might be just me, IMO at this point v4_pcr can just be v4 or something like this, but again, it's such a hesitant nitpick that I won't block a PR on it, depends on you if you agree to make a change or not, otherwise LGTM!
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/hil full --test i2c,spi |
|
Triggered full HIL run for #6033. Run: https://github.com/esp-rs/esp-hal/actions/runs/31090900994 Status update: ❌ HIL (full) run failed (conclusion: failure). |
4 participants
This PR introduces v4 for and follows UART implementation from #5528.
cc #5959 (comment)