feat: check duplicate comma-separated @keyframe selectors - #522
Open
Tanujkanti4441 wants to merge 2 commits into
Open
feat: check duplicate comma-separated @keyframe selectors#522Tanujkanti4441 wants to merge 2 commits into
Tanujkanti4441 wants to merge 2 commits into
Conversation
3 tasks
DMartens
reviewed
Aug 2, 2026
DMartens
approved these changes
Aug 6, 2026
DMartens
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM, thanks. As this is a feature leaving open for a second review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
To also check the duplicate @Keyframe selectors that are comma-separated.
What changes did you make? (Give an overview)
Added a loop to go through every selector in a rule instead of just the first one to enable checking comma-separated selectors as duplicates, and added related test cases also. Now rule
no-duplicate-keyframe-selectorswill also report cases such as:Related Issues
Fixes #459
Is there anything you'd like reviewers to focus on?