Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion desktop/frontend/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4915,6 +4915,11 @@ export default function App() {
onManageAllowlist={() => openBotAllowlistSettings(sidebarImDetailConnection.connectionId)}
onOpenSession={() => void openSidebarImConnectionSession(sidebarImDetailConnection)}
/>
) : transcriptHydrating ? (
<div className="loading-screen" role="status" aria-live="polite">
<span className="loading-screen__spinner" aria-hidden="true" />
<span className="loading-screen__text">{t("common.loading")}</span>
</div>
) : noticePreviewMockEnabled() ? (
<NoticePreviewPanel />
) : (
Expand Down Expand Up @@ -5292,7 +5297,12 @@ export default function App() {
</div>
</div>
<div className="workbench-dock__body">
{rightDockMode === "remote" ? (
{transcriptHydrating ? (
<div className="loading-screen" role="status" aria-live="polite">
<span className="loading-screen__spinner" aria-hidden="true" />
<span className="loading-screen__text">{t("common.loading")}</span>
</div>
) : rightDockMode === "remote" ? (
<Suspense fallback={null}>
<RemotePanel onClose={() => setWorkspacePanel(false)} />
</Suspense>
Expand Down
13 changes: 13 additions & 0 deletions desktop/frontend/src/__tests__/app-chrome-tabs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,19 @@ ok(
"Welcome is suppressed only until transcript history has loaded",
);

ok(
Array.from(appSource.matchAll(/transcriptHydrating \? \(/g)).length === 2 &&
/<div className="loading-screen" role="status" aria-live="polite">/.test(appSource) &&
/loading-screen__text">\{t\("common\.loading"\)\}/.test(appSource) &&
/workbench-dock__body">[\s\S]*?\{transcriptHydrating \? \(/.test(appSource),
"tab switching shows a loading placeholder in both the transcript and right dock until history hydrates",
);
ok(
matchingBlocks(".loading-screen").length === 1 &&
/height: 100%/.test(matchingBlocks(".loading-screen")[0]),
"loading-screen shell fills the transcript and right dock while hydrating",
);

ok(
/const creationEmptyHero =/.test(appSource) &&
/!sidebarImDetailConnection/.test(appSource) &&
Expand Down
5 changes: 4 additions & 1 deletion desktop/frontend/src/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -3005,9 +3005,12 @@ a[href] {
flex-direction: column;
}

/* loading screen shown while boot.Build runs in the background */
/* loading screen shown while boot.Build runs in the background; also the
placeholder while a tab's history hydrates after switching (height: 100%
lets it fill the non-flex right dock body). */
.loading-screen {
flex: 1;
height: 100%;
display: flex;
flex-direction: column;
align-items: center;
Expand Down
32 changes: 16 additions & 16 deletions tools/repolint/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
"limits": {
"banner": 15,
"commented-code": 0,
"complexity": 2096,
"essay": 4082,
"file-size": 110104,
"function-size": 9159,
"complexity": 2095,
"essay": 4081,
"file-size": 110089,
"function-size": 9152,
"layering": 1,
"marker": 0,
"narrative": 64,
"test-file-size": 69905
"test-file-size": 69916
},
"files": {
"cmd/e2ebench/main.go": {
Expand All @@ -27,8 +27,8 @@
},
"desktop/app.go": {
"complexity": 63,
"essay": 96,
"file-size": 11489,
"essay": 95,
"file-size": 11484,
"function-size": 381
},
"desktop/app_autosave_test.go": {
Expand Down Expand Up @@ -84,10 +84,10 @@
"essay": 2
},
"desktop/frontend/src/App.tsx": {
"file-size": 4733
"file-size": 4743
},
"desktop/frontend/src/__tests__/app-chrome-tabs.test.ts": {
"test-file-size": 19
"test-file-size": 32
},
"desktop/frontend/src/__tests__/capabilities-panel-actions.test.ts": {
"test-file-size": 307
Expand Down Expand Up @@ -308,7 +308,7 @@
"desktop/tabs.go": {
"complexity": 74,
"essay": 133,
"file-size": 8716,
"file-size": 8715,
"function-size": 630
},
"desktop/tabs_order_test.go": {
Expand Down Expand Up @@ -498,8 +498,8 @@
"internal/agent/execute_one.go": {
"complexity": 13,
"essay": 23,
"file-size": 157,
"function-size": 20
"file-size": 142,
"function-size": 18
},
"internal/agent/extensions.go": {
"essay": 64
Expand Down Expand Up @@ -1073,13 +1073,13 @@
"internal/control/controller.go": {
"complexity": 10,
"essay": 162,
"file-size": 5420,
"file-size": 5416,
"function-size": 75,
"narrative": 4
},
"internal/control/controller_test.go": {
"essay": 10,
"test-file-size": 4610
"test-file-size": 4608
},
"internal/control/errmsg.go": {
"essay": 2
Expand Down Expand Up @@ -1166,9 +1166,9 @@
"essay": 1
},
"internal/control/turn_orchestrator.go": {
"complexity": 2,
"complexity": 1,
"essay": 13,
"function-size": 60
"function-size": 55
},
"internal/control/turn_orchestrator_test.go": {
"essay": 1,
Expand Down