Repository navigation
Fix the ftol and xtol descriptions of sade, de1220, cmaes and xnes - #652
Merged
Merged
Conversation
tachsin
added a commit
to tachsin/genoxide
that referenced
this pull request
Sep 28, 2026
#288) I reported every library bug the benchmarks found, each with a reproduction and a proposed fix, and this links them from the notes and the library pages in place of "not yet": - pymoo: #799-#808 (the DE index draw that halves its Rastrigin error is #799, fix #800) - jMetal: #490-#497 (CMA-ES C^(−1/2) and `tql2`, χ_n, seeds, coral reef crash) - Evolutionary.jl (now SciML/Evolutionary.jl): #179-#186 (CMA-ES, GA copies, DE, (μ+λ)-ES) - PyGAD: #370-#376 (and a fix for #369) - radiate: #29, #30 - pagmo / pygmo: esa/pagmo2#652-#654, esa/pygmo2#195-#196 - Metaheuristics.jl: #130, #131 - DEAP: #778-#782 Nevergrad's `NgIohTuned` crash and pymoo's pattern search seeding are already fixed on their main branches, not yet released; the pages say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs esa/pygmo2#195.
The constructor docs of
sade,de1220,cmaesandxnesdescribedftolas the stopping criterion on the x tolerance andxtolas the one on the f tolerance. The code uses them the other way round (e.g.cmaes.cpp:m_xtolbounds the step,m_ftolthe fitness difference), andde's docs already have them the right way. This swaps the two descriptions in the four headers. The pygmo docstrings get the same fix in esa/pygmo2.Documentation only. I built the library and the
sade,de1220,cmaesandxnestests with it, and they pass.