-
Notifications
You must be signed in to change notification settings - Fork 93
Bound the other two PostgreSQL collectors that had no ceiling #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,7 +119,13 @@ JOIN pg_catalog.pg_namespace AS n | |
| WHERE s.schemaname NOT IN ('pg_catalog', 'information_schema') | ||
| AND c.relkind IN ('r', 'm', 'p') | ||
| AND c.relpages >= 128 | ||
| ORDER BY c.relpages DESC, s.schemaname, s.tablename, s.attname"; | ||
| ORDER BY c.relpages DESC, s.schemaname, s.tablename, s.attname | ||
| /* Bounded (#2617's lesson applied before it bites). This is a catalog read rather than a page scan, so | ||
| it is nowhere near as costly as pg_index_bloat was - but it was still unbounded, and row count here is | ||
| tables x columns: 361 tables over the size floor on one measured target, and a wide schema turns that | ||
| into five figures per database per DAY. The ORDER BY already puts the biggest tables first, so the cap | ||
| keeps exactly the columns a plan-shape question is asked about. */ | ||
| LIMIT 5000"; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same gap as |
||
|
|
||
| public override string Name => "pg_column_stats"; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No pinning test for this override. The sibling fix in #2618 (
PgIndexBloatCollector) added a regression guard inLite.Tests/PgIndexBloatCollectorDefinitionTests.cs:PgBufferUsageCollectorDefinitionTests.cshas no equivalent assertion, so a future edit that drops or lowers this override (undoing the fix this PR exists to make) wouldn't be caught by the test suite — only by another production incident like #2617.