Repository navigation
Apply standard formatting with clang-format - #86
Merged
Merged
Conversation
basic formatting style to standardize formatting across files and fix broken formatting in some files. pre-commit configuration is added to enforce this formatting.
Contributor
|
@ericonr Thanks -- I agree with you that the formatting is sort of a mess, and that using pre-commit with some convention is a good idea. Not working in C++very much myself, I have no strong opinion on formatting conventions, and am probably more likely to not follow common conventions instinctively. So, having a pre-commit format checker should help. I'll merge this, and hope that makes #87 easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code has many problems with wonky formatting and indentation, which makes reading and maintaining the code more complicated. Instead of fixing these manually, simply apply a standard code style.
In order to avoid such a commit polluting history investigations, after merging it can be added to the
.git-blame-ignore-revsfile:https://gist.github.com/kateinoigakukun/b0bc920e587851bfffa98b9e279175f2