Repository navigation
Make user record DESC field values consistent - #45
Merged
Merged
Conversation
The DESC field values of some user records are not consistent with others. For example, one might have a space before the record instance number, while the rest do not. Or some might have a space after "user" when others do not. Or some might start with "User" when others start with "user". Make them all consistent.
Member
|
I think this PR is fine. However, in practice it won't have much effect. The .DESC fields for all these records are the .req files, and hence in autosave. If users load these new .db files into an existing IOC they won't see the changes, because those values will be overridden by the autosaved values. Additionally the .DESC fields are really meant to be modified to give meaningful descriptions to the calculations, so the values in the .db files are often intentionally replaced and these new values are restored with autosave. |
Contributor
Author
|
Agreed. I happened to add them to a new IOC and then saw this, so I thought I'd fix it. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DESCfield values of some user records are not consistent with others. For example, one might have a space before the record instance number, while the rest do not. Or some might have a space after "user" when others do not. Or some might start with "User" when others start with "user".Here are some examples of MEDM screens showing this:
Make them all consistent.