Repository navigation
Add parking payment methods and repair payment process values - #1775
Merged
a-limyr merged 2 commits intoOct 23, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
teppope
force-pushed
the
fix/parking-payment-methods-not-editable
branch
from
October 9, 2026 13:54
bdb35e0 to
a807aaa
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a-limyr
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paymentMethodsfield to the parking editor. The change adds a GraphQL field, locale labels and a multi-select control in the modern editor.parkingPaymentProcessto the four values that the NeTEx Nordic profile allows:free,payAndDisplay,payByPrepaidTokenandpayByMobileDevice. A stored value outside this list still renders, and a save keeps it.parkingPaymentProcesslabel in all five locale files, from "Payment method" to "Payment process". The field names a process, not a method. The newpaymentMethodsfield now owns the "Payment method" wording.defaultMessagefallback to every enum label lookup. A stop place that holds an untranslated value now shows the raw value, not a blank string.Type of change
Issue
Tiamat stores
paymentMethods, but the editor had no control for it. TheparkingPaymentProcesslabel used the "Payment method" wording, so a user could not tell the two fields apart.A user clears
paymentMethodswith an empty selection. The editor then sends an empty list, and Tiamat clears the stored list.Unit tests
AssertionError: expected [ 'free', 'other', …(7) ] to deeply equal [ 'free', 'payAndDisplay', …(2) ].Verification
npx tsc --noEmitnpm run check(Prettier)vitest runParking,ParkingPaymentProcess. The editor offers exactly the four valuesPayment processreplaces the wrongParking payment methodlabel, andPayment methodsis new