-
Notifications
You must be signed in to change notification settings - Fork 1
small fixes 2026-08-17 (2): s2_neon_o9 toc flip, CHANGELOG entry for PR #447 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ceeb9f3
flip the s2_neon_o9 benchmark config to time_encoding: toc (issue #451)
espg 43fbeed
changelog entry for the PR #447 mortie_order default and build path (…
espg df6714d
fold review: quote the default-order speedup the bullet describes (is…
espg 4f02e5c
fold review: scope the explicit-pin unchanged claim to the resolved o…
espg 52b2531
fold review: pin the shipped config's pyramid absence too (issue #451)
espg 44bc654
fold review: resolve the bench config through the targets manifest (i…
espg c3f9010
fold review: file the #447 entry under 0.46.0 (issue #453)
espg a87320c
sync with main post-#420 (issues #453/#451)
espg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 from Claude (review)
The divergence budget is enforced one-sidedly:
pyramidis dropped from the comparison on both sides but asserted only on the bench side, so the shipped config can grow any pyramid declaration and this test still passes.normalized()excludes"pyramid"(line 65), and line 74 pins onlybench.output["pyramid"] is False. Nothing constrainsshipped.output.Verified by mutation on this branch — a harness reproducing the test body verbatim (
data_source/aggregationequality,semantic_hash,normalized(), theparent_orderpops,b == s, the line-74 pin), run againstload_config-loaded copies of both configs:The hole is not incidental: the one output key exempted from the dict comparison is the same key the docstring names as half the divergence budget ("Divergence budget: parent_order and the harness's pyramid opt-out"). The stated purpose — "a knob added to one and not the other (as time_encoding was, issue #443) cannot drift silently" — holds for every knob except this one. And
pyramidis not inert like the two other drops:src/zagg/configs/sentinel2_l2a.yamlacquiringpyramid: {overviews: [...]}(the issue #382 grammar) turns the overview family on for the shipped product while the leg keeps measuring it off, at an unchanged semantic hash —output.pyramidnever enterssemantic_core, so the D19 assertion above cannot see it either.One line next to 74 closes it:
assert "pyramid" not in shipped.output.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 from Claude
Fixed in
52b2531— your one-liner, with a comment naming why the hole exists (thepyramiddrop fromnormalized()plusoutput.pyramidbeing outsidesemantic_core, so neither the dict comparison nor D19 can see it):The
normalized()drop stays on both sides as-is; only the assertion is now two-sided.uv run --extra test pytest tests/test_raster_benchmark.py -q→ 11 passed.Separately in
44bc654, this test now resolves the bench config through the targets manifest (base / manifest["targets"]["raster_s2_neon_2025"]["config"]) instead of the hardcodedBENCH / "configs" / "s2_neon_o9.yaml", matchingtest_raster_targets_manifest_consistentbeside it — so a manifest repoint cannot leave this test parity-checking a stale file.