Skip to content

Update NonBlockingRtttl.cpp #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chechi666 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update NonBlockingRtttl.cpp #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/NonBlockingRtttl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ void nextnote();
// and https://github.com/espressif/arduino-esp32/issues/1720
#if defined(ESP32)
void noTone(){
ledcWrite(0, 0); // channel, volume
ledcWrite(pin, 0); // channel, volume
}

void noTone(int pin){
noTone();
}

void tone(int frq) {
ledcWriteTone(0, frq); // channel, freq
ledcWrite(0, 255); // channel, volume
ledcWriteTone(pin, frq); // channel, freq
ledcWrite(pin, 255); // channel, volume
}

void tone(int pin, int frq, int duration){
Expand All @@ -72,8 +72,7 @@ void begin(byte iPin, const char * iSongBuffer, byte iLoopCount, unsigned long i
//init values
pin = iPin;
#if defined(ESP32)
ledcSetup(0, 1000, 10); // resolution always seems to be 10bit, no matter what is given
ledcAttachPin(pin, 0);
ledcAttach(pin, 1000, 10);
#endif
buffer = iSongBuffer;
bufferIndex = 0;
Expand Down