Avoid redundant redraw requests in native run loop - #8341
Open
rustbasic wants to merge 12 commits into
Open
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8341-p107 View snapshot changes at kitdiff |
Add logic to repaint root window after deferred viewport updates.
Contributor
Author
|
The fact that the Solved : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid redundant redraw requests in native run loop
pure_glowhigh CPU usage #7401Summary
Avoid repeatedly requesting redraws for the same native window while a previous
request_redraw()is still pending.Details
request_redraw()schedules a futureWindowEvent::RedrawRequested. In reactiveapps, repeatedly calling
request_redraw()before that event is delivered cankeep the event loop unnecessarily busy.
This PR adds per-window pending redraw tracking:
request_redraw()is calledWindowEvent::RedrawRequestedThe run loop now also falls back to
ControlFlow::Waitwhen there is no nextscheduled repaint, instead of relying on
ControlFlow::Poll.This should reduce redundant redraw requests and unnecessary CPU usage in
reactive native applications.